-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support GHC 9.10 #494
Support GHC 9.10 #494
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Thanks for the fixes! Would you mind extending our CI build matrix to include 9.10? I'd be happy if you repurpose the cabal build with ghc 9.6 / cabal test for this. We already have 9.10 covered by Stack and I don't see ghc-9.10 in stackage yet. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me if everything passes and the file noted removed.
Thanks @9999years ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thanks again @9999years
Thanks for doing this! Any chance of a release? :) |
I don't mind pushing the release button, but I'm not likely to find the time to do the version increment. We also got some awesome new features like protobuf editions support courtesy of @chungyc. I'd like somebody to note them down properly in the affected packages' changelogs. |
Also, since we have a release of ghc-source-gen 0.4.6.0 up, we should be able to simplify this: proto-lens/ghc9.10.1.cabal.project Lines 6 to 9 in c927e03
|
Depends on: google/ghc-source-gen#117